Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move single_line_empty_body to @PER-CS2.0 #7282

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Sep 8, 2023

Fixes #7269.

Initially single_line_empty_body was added to @PhpCsFixer, but since #7249 was merged, we can move it to PER-CS v2 (reference).

@Wirone Wirone self-assigned this Sep 8, 2023
@Wirone Wirone mentioned this pull request Sep 8, 2023
16 tasks
@Wirone Wirone force-pushed the codito/single-line-empty-body-in-per-cs-v2 branch from e5d8c46 to 8061e66 Compare September 8, 2023 21:55
@coveralls
Copy link

coveralls commented Sep 8, 2023

Coverage Status

coverage: 94.639%. remained the same when pulling 8061e66 on Wirone:codito/single-line-empty-body-in-per-cs-v2 into ca99f36 on PHP-CS-Fixer:master.

@keradus
Copy link
Member

keradus commented Sep 9, 2023

does it close #7269 ?

@Wirone
Copy link
Member Author

Wirone commented Sep 9, 2023

@keradus yes, it does, thanks for catching it, I forgot you created an issue for that 🙂.

@Wirone Wirone merged commit 3b18ca7 into PHP-CS-Fixer:master Sep 9, 2023
13 checks passed
@Wirone Wirone deleted the codito/single-line-empty-body-in-per-cs-v2 branch September 9, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_line_empty_body should be part of @PER
3 participants