Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions/reusable-phpstan.yml: add "version" configurable option #2

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 8, 2024

This Monday, PHPStan 2.0 will be released.

To allow for packages which use this reusable workflow to choose whether to stay on PHPStan 1.x or to (automatically) move to PHPStan 2.x, this commit adds a new, optional version input option for the reusable PHPStan workflow.

  • When not set, the workflow will instruct setup-php to install the latest available PHPStan version (same as before).
  • When set, the workflow will instruct setup-php to install whatever version was given.

The version number provided by the calling workflow should comply with the supposed ways of providing a version nr as per setup-php: https://github.com/shivammathur/setup-php/?tab=readme-ov-file#wrench-tools-support

This Monday, [PHPStan 2.0 will be released](https://phpc.social/@OndrejMirtes/113441109253809720).

To allow for packages which use this reusable workflow to choose whether to stay on PHPStan 1.x or to (automatically) move to PHPStan 2.x, this commit adds a new, optional `version` input option for the reusable PHPStan workflow.

* When not set, the workflow will instruct setup-php to install the latest available PHPStan version (same as before).
* When set, the workflow will instruct setup-php to install whatever version was given.

The version number provided by the calling workflow should comply with the supported ways of providing a version nr as per setup-php: https://github.com/shivammathur/setup-php/?tab=readme-ov-file#wrench-tools-support
@jrfnl jrfnl added the enhancement New feature or request label Nov 8, 2024
@jrfnl jrfnl merged commit 99cede7 into main Nov 8, 2024
8 checks passed
@jrfnl jrfnl deleted the feature/ghactions-reusable-phpstan-add-version branch November 8, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant