Merge pull request #458 from rodrigoprimo/disallow-yoda-condition-dro…

…p-null-coalescing-operator Generic/DisallowYodaConditions: `??` should not trigger the sniff
PHPCSStandards · Apr 22, 2024 · 5f38ce0 · 5f38ce0
2 parents 8d2363d + e4d3743
commit 5f38ce0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Standards/Generic/Sniffs/ControlStructures/DisallowYodaConditionsSniff.php b/src/Standards/Generic/Sniffs/ControlStructures/DisallowYodaConditionsSniff.php
@@ -25,7 +25,10 @@ class DisallowYodaConditionsSniff implements Sniff
      */
     public function register()
     {
-        return Tokens::$comparisonTokens;
+        $tokens = Tokens::$comparisonTokens;
+        unset($tokens[T_COALESCE]);
+
+        return $tokens;
 
     }//end register()
 

diff --git a/src/Standards/Generic/Tests/ControlStructures/DisallowYodaConditionsUnitTest.inc b/src/Standards/Generic/Tests/ControlStructures/DisallowYodaConditionsUnitTest.inc
@@ -173,3 +173,5 @@ echo match ($text) {
     'foo' => 10 === $y,
     10 === $y => 'bar',
 };
+
+1 ?? $nullCoalescingShouldNotTriggerSniff;