-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add unit tests for Common::prepareForOutput() #663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatmaRex This is great ! Thank you for adding these tests.
I've left a few small comments to have a look at.
Other than that, maybe there should also be a test case which doesn't do any replacements, not on Windows, nor on Linux. Something like this maybe ?
'No replacements' => [
'content' => 'nothing-should-be-replaced',
'exclude' => [],
'expected' => 'nothing-should-be-replaced',
'expectedWin' => 'nothing-should-be-replaced',
],
If you rebase the PR, you can remove the @author
tag.
Once that's done, I'll add an extra commit to the PR to enable running the tests on Windows in GH Actions.
1d8aa22
to
8bee9c4
Compare
This function has different behavior on Windows and on other systems, therefore add two tests, only one of which runs.
8bee9c4
to
a220c80
Compare
Thank you for the review, addressed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatmaRex Thank you for making those updates! I've now added that extra commit to enable running the tests on Windows. 🤞🏻
Once the build has run (and passed), I'll merge this PR.
be92a4b
to
f7dcac5
Compare
Sorry for the commit noise, just tweaking a step to (hopefully) get code coverage running on Windows too. |
b939bb4
to
7bdab2b
Compare
For the `quicktest` and the `coverage` jobs, only select tests which are marked with `@group Windows` will be run. For the "normal " `test` job, all tests will now be run on Windows too.
Again, sorry for the commit noise. Looks like I've finally got it working correctly. I'm going to squash the CI commits now. Once the build has finished once again, I'll merge this. |
170a79a
to
755f0bc
Compare
Thanks! |
This function has different behavior on Windows and on other systems, therefore add two tests, only one of which runs.
Types of changes
PR checklist