Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators/Text: trim code titles #738

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 27, 2024

Description

As things were, whitespace at the start/end of a title could cause unnecessary line wrapping of the title.

Fixed now.

Includes updated test expectations.

Before

5-code-title-text-whitespace-before

After

5-code-title-text-whitespace-after

Suggested changelog entry

Generators/Text: minor clean up of code title presentation

Related issues/external references

This PR is part of a series of PRs which will add a complete set of tests (and improvements) for the Generator feature.

Also see: #671 and #718.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

As things were, whitespace at the start/end of a title could cause unnecessary line wrapping of the title.

Fixed now.

Includes updated test expectations.
@jrfnl jrfnl added this to the 3.11.2 milestone Nov 27, 2024
@jrfnl jrfnl merged commit d77d651 into master Dec 1, 2024
59 checks passed
@jrfnl jrfnl deleted the feature/generator-text-trim-code-titles branch December 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant