CHANGE: Local projects uses relative paths to their coding standards #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
approved these changes
May 10, 2017
src/Plugin.php
Outdated
| @@ -242,7 +244,12 @@ private function cleanInstalledPaths() | |||
| { | |||
| $changes = false; | |||
| foreach ($this->installedPaths as $key => $path) { | |||
| if (file_exists($path) === false || is_dir($path) === false || is_readable($path) === false) { | |||
| // This might be an relative path as well | |||
| @@ -270,14 +278,21 @@ private function updateInstalledPaths() | |||
|
|
|||
| $finder = new Finder(); | |||
| $finder->files() | |||
| ->ignoreUnreadableDirs() | |||
|
|
||
| /** | ||
| * Test if composer is running "global" | ||
| * This check kinda dirty, but it is the "Composer Way" |
src/Plugin.php
Outdated
|
|
||
| // Some compatibility fixes for Windows paths | ||
| $from = is_dir($from) ? rtrim($from, '\/') . '/' : $from; | ||
| $to = is_dir($to) ? rtrim($to, '\/') . '/' : $to; |
There was a problem hiding this comment.
Too much whitespace between ) ?.
| * | ||
| * @return string Relative path | ||
| */ | ||
| private function getRelativePath($to) |
There was a problem hiding this comment.
This code is going to be a bastard to test 😿
frenck
force-pushed
the
feature/relative-paths-support
branch
from
c9b7c6b to
d39ee79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changed they way paths are put into PHP_CodeSniffer based on Composer being executes globally or not. Local repositories (project folder) installations will use relative paths from the PHP_CodeSniffer installation directory to the directory containing the coding standard.
The behaviour for globally installed instances will keep using absolute paths; unchanged.
Related Issues
#20 Install sniffs with relative paths in CodeSniffer.conf