Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

insertNewRowBefore is not working #275

Closed
gibito opened this issue Nov 25, 2013 · 3 comments
Closed

insertNewRowBefore is not working #275

gibito opened this issue Nov 25, 2013 · 3 comments
Milestone

Comments

@gibito
Copy link

gibito commented Nov 25, 2013

Repro:

  1. Fill, for instance, cells A1,B2,C1,C2,C4 with arbitrary values

  2. Set C3=A1_B2_C1_C2_C4

  3. Call insertNewRowBefore(1,1) and observe that the formula is corrupted: =A2_B3_C3_C3_C5

@gibito
Copy link
Author

gibito commented Dec 6, 2013

@MarkBaker

Please see commit GerHobbelt@7d6f6e0 for an example of this bug: that commit edits the 03formulas.php example file that comes with PHPExcel to reproduce the error: the sum cell (B5=B2+B3+B4, all moved down one row by the InsertNewRowBefore() in the patched example) should read after the insert-row: B6=B3+B4+B5. However the actual result is B6=B5+B5+B5.

We have not investigated why the insertRow operation has this incorrect effect on the formula rewrite process.

MarkBaker pushed a commit that referenced this issue Dec 9, 2013
MarkBaker pushed a commit that referenced this issue Dec 9, 2013
@GerHobbelt
Copy link

Tested with my patched 03formulas.php: that example now works okay. Looking good.
Going to test it on our (@gibito + @GerHobbelt) application code next...

@gibito gibito closed this as completed Dec 10, 2013
@gibito
Copy link
Author

gibito commented Dec 10, 2013

Fixed in fcb794e

@Progi1984 Progi1984 added this to the 1.8.0 milestone Aug 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants