Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Wrong check for maximum number of rows #66

Closed
AndreKR opened this issue Oct 23, 2012 · 1 comment
Closed

Wrong check for maximum number of rows #66

AndreKR opened this issue Oct 23, 2012 · 1 comment
Labels
Component - Excel5
Milestone
1.8.0

Comments

@AndreKR
Copy link

AndreKR commented Oct 23, 2012

In https://github.com/PHPOffice/PHPExcel/blob/develop/Classes/PHPExcel/Writer/Excel5/Parser.php#L948-950 and https://github.com/PHPOffice/PHPExcel/blob/develop/Classes/PHPExcel/Writer/Excel5/Parser.php#L982-988 the row index is checked to be not greater than 16384. As we now only use BIFF8 this should be changed to 65536.
MarkBaker pushed a commit that referenced this issue Oct 25, 2012
Bugfix: Work item GH-66 - Wrong check for maximum number of rows in E…
45f2829 
…xcel5 Writer
@MarkBaker
Copy link
Member

Fixed in develop branch, thanks for the checking

@Progi1984 Progi1984 added this to the 1.8.0 milestone Aug 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component - Excel5
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
3 participants
@MarkBaker @AndreKR @Progi1984