Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Cache directory for DiscISAM cache storage cannot be set #67

Closed
AndreKR opened this issue Oct 24, 2012 · 2 comments
Closed

Cache directory for DiscISAM cache storage cannot be set #67

AndreKR opened this issue Oct 24, 2012 · 2 comments
Labels
Type - Bug
Milestone
1.8.0

Comments

@AndreKR
Copy link

AndreKR commented Oct 24, 2012

In https://github.com/PHPOffice/PHPExcel/blob/develop/Classes/PHPExcel/CachedObjectStorageFactory.php#L103-104 the dirparameter of the DiscISAM method is set to NULL.

In https://github.com/PHPOffice/PHPExcel/blob/develop/Classes/PHPExcel/CachedObjectStorageFactory.php#L199-204 only parameters for which isset() is true are set. isset(NULL)is false, so the dir parameter can never be set.
MarkBaker pushed a commit that referenced this issue Nov 20, 2012
Bugfix: Work item GH-67 - Cache directory for DiscISAM cache storage …
8a967b2 
…cannot be set
@MarkBaker
Copy link
Member

modified isset() test to use array_key_exists() instead

@Progi1984 Progi1984 added this to the 1.8.0 milestone Aug 14, 2014
@dalecosp
Copy link

Thanks Andre and Mark! Was definitely causing an issue in some backend production systems here at OMBE.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type - Bug
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
4 participants
@MarkBaker @AndreKR @Progi1984 @dalecosp