-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/Cell.php does not accept null values to unset some values #2673
Labels
Milestone
Comments
I wouldn't mind creating a PR for that if allowing |
SpraxDev
added a commit
to SpraxDev/PHPWord
that referenced
this issue
Sep 12, 2024
…ce#2673) vAlign and vMerge are initialized as `null` in every style until it is explicitly set. Right now, it is not possible to unset them, after it has been set once. I've added a null-check to skip the validation, based on the default parameter value of `null`, which indicates to me that it once was intended to work like this. I've also fixed the type-hints, which were wrong from the start.
4 tasks
SpraxDev
added a commit
to SpraxDev/PHPWord
that referenced
this issue
Sep 13, 2024
…ce#2673) vAlign and vMerge are initialized as `null` in every style until it is explicitly set. Right now, it is not possible to unset them, after it has been set once. I've added a null-check to skip the validation, based on the default parameter value of `null`, which indicates to me that it once was intended to work like this. I've also fixed the type-hints, which were wrong from the start.
Progi1984
pushed a commit
that referenced
this issue
Sep 13, 2024
* fix: Allow vAlign and vMerge on Style\Cell to be set to null (#2673) vAlign and vMerge are initialized as `null` in every style until it is explicitly set. Right now, it is not possible to unset them, after it has been set once. I've added a null-check to skip the validation, based on the default parameter value of `null`, which indicates to me that it once was intended to work like this. I've also fixed the type-hints, which were wrong from the start. * docs(changelog): Add note about supporting vAlign and vMerge to be unset * test: Extend existing table test case to check if unsetting vAlign works * test: Add test case to check if unsetting vMerge works This should fix the reduction in test coverage because of the new null checking code in the Setter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug and add attachments
Some values like vMerge and vAlign are type-hinted as
string
(not nullable) although they are initialized asnull
until explicitly set/parsed.That means, there is no proper way to unset some values where it would make sense to 'remove' that attribute.
The parameter for
setVMerge
andsetVAlign
for example even has a default value ofnull
set, which is not valid according to its type-hint and makes everything even more confusing.Expected behavior
I think it would make sense to allow
null
to be set for some attributes and everything to be type-hinted accordingly.Steps to reproduce
PHPWord version(s) where the bug happened
master
PHP version(s) where the bug happened
8.3 and all the others
Priority
The text was updated successfully, but these errors were encountered: