Split global.js into multiple files #134
Assignees
Labels
Enhancement
New feature or request
Comments
JSKitty
added a commit
that referenced
this issue
May 29, 2023
JSKitty
changed the title
JSKitty
added a commit
that referenced
this issue
Jun 2, 2023
* Full Redeem implementation and UI * Hide redeem button during redeems * Upgrade to PIVX Promos v0.2.0, optimise redeems * Implement basic Promo Code Creation * [HTML, CSS, JS] More responsive and animated * [JS] Supress small error when element is not found * Prettify + improve Create UX * Add DB persistance to the Promo Creator * Add code tracking + UX fixes * Add CSS, copy button and explorer link to codes * fix: Smooth table animation * Move promo fee to a const * Fix update ticks * Add Entropy system + UX Sanity checks * fix: Don't allow deleting Unclaimed codes * fix: Unlock prompting and render-skipping * Explain the promo creation unlock prompt * Split from global.js to promos.js for #134 * fix: state update bugs --------- Co-authored-by: BreadJS <83626012+BreadJS@users.noreply.github.com>
Liquid369
pushed a commit
to Liquid369/MyPIVXWallet
that referenced
this issue
Aug 2, 2023
* Full Redeem implementation and UI * Hide redeem button during redeems * Upgrade to PIVX Promos v0.2.0, optimise redeems * Implement basic Promo Code Creation * [HTML, CSS, JS] More responsive and animated * [JS] Supress small error when element is not found * Prettify + improve Create UX * Add DB persistance to the Promo Creator * Add code tracking + UX fixes * Add CSS, copy button and explorer link to codes * fix: Smooth table animation * Move promo fee to a const * Fix update ticks * Add Entropy system + UX Sanity checks * fix: Don't allow deleting Unclaimed codes * fix: Unlock prompting and render-skipping * Explain the promo creation unlock prompt * Split from global.js to promos.js for PIVX-Labs#134 * fix: state update bugs --------- Co-authored-by: BreadJS <83626012+BreadJS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
global.jscomes from the times where 90% of the code was in index.html, it was supposed to be a temporary file until we got things sorted out. Things are much better now, but we can do better.I think it would be intuitive to split every tab into a new file (intro.js, dashboard.js, governance.js, ...). This will also allow code splitting to reduce the inital loading time.
The text was updated successfully, but these errors were encountered: