Add ledger persistance #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Tested hard and soft refresh, also unplugged Ledger and refreshed. I was able to still use the wallet for stuff that doesn't need spending authority. |
JSKitty
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Authorative tACK 6d60a9b on behalf of @PalmTreeVI - code also looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This is a QOL feature for ledger users. It remembers the ledger account upon when logging in, so they don't have to plug in the ledger each time.
It also gives them access to contacts and easier masternode management.
Testing
Closes #270