Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ledger persistance #381

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Aug 27, 2024

Abstract

This is a QOL feature for ledger users. It remembers the ledger account upon when logging in, so they don't have to plug in the ledger each time.
It also gives them access to contacts and easier masternode management.


Testing

  • Log in with ledger
  • Refresh the page and check that you can still use the wallet for stuff that doesn't need spending authority

Closes #270

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 6d60a9b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/66d0c40c19ab5d0008c4cf9d
😎 Deploy Preview https://deploy-preview-381--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSKitty JSKitty added the Enhancement New feature or request label Aug 27, 2024
@PalmTreeVI
Copy link

Tested hard and soft refresh, also unplugged Ledger and refreshed. I was able to still use the wallet for stuff that doesn't need spending authority.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorative tACK 6d60a9b on behalf of @PalmTreeVI - code also looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve hardware wallet UX
3 participants