Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
76fb659 Remove TorV2 checks for TorV3 addr verification (Liquid) Pull request description: This pull request creates TorV3 Address parsing functionality. TorV2 was depreciated nearly 2 years ago and should not have access to the Tor network anymore. Therefore we need to support TorV3 for users now in SPMT. Problems still arise, because this work relies on the work done in this PR as well: PIVX-Project/PIVX#2873 SPMT uses `decodemasternodebroadcast` and `relaymasternodebroadcast` which get updated in the above PR. We have removed TorV2 checks entirely because they should not be functional. Successful Broadcast Creation: ![image](https://github.com/PIVX-Project/PIVX-SPMT/assets/45834289/3ad52805-e59a-409d-bf1c-bea74584e8aa) Successfully Started: ![image](https://github.com/PIVX-Project/PIVX-SPMT/assets/45834289/ddb07b03-80d9-41b3-814e-5c97ee6d3981) Verification on daemon: ```pivx-cli -rpcconnect=127.0.0.2 getmasternodestatus { "txhash": "07b9b7beeb74c0bcef1d004c83b1ff741f776f2e4a6b6e8cf78ce7b8970d7b53", "outputidx": 0, "netaddr": "ovt6bxnzdj6afty22ccayzkuxnhhfuqjbn5gubmps4velhsxbmct6qyd.onion:51472", "addr": "DRndVQTocPwbPGRUzCUeFhXu36NerLsBHR", "status": 4, "message": "Masternode successfully started" } ``` Key things to TorV3 address parsing: Network ID as a PREFIX is 0x04 in determining its a TORV3 address through network messages Version is always '\x03' which is the 'd' at the end of the .onion address (last char before .onion) Length is always 62 characters and 35 bytes length. ACKs for top commit: Fuzzbawls: ACK 76fb659 Tree-SHA512: 6d8d544fb662cdd9b11cdaaf4b557d5e5a7a86d8e46de9719097c7b551937dfd7151ac91f558fd1d5e35dad41201ee92c6f9c95c6fa6154b8bf9633a7d082329
- Loading branch information