Add warnings field to getblockchaininfo

PIVX-Project · Jun 2, 2021 · 1d966ce · 1d966ce
1 parent ffcd781
commit 1d966ce
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -24,6 +24,7 @@
 #include "hash.h"
 #include "validationinterface.h"
 #include "wallet/wallet.h"
+#include "warnings.h"
 
 #include <stdint.h>
 #include <univalue.h>
@@ -1010,6 +1011,7 @@ UniValue getblockchaininfo(const JSONRPCRequest& request)
             "        \"info\": \"xxxx\",        (string) additional information about upgrade\n"
             "     }, ...\n"
             "}\n"
+            "  \"warnings\" : \"...\",         (string) any network and blockchain errors.\n"
 
             "\nExamples:\n" +
             HelpExampleCli("getblockchaininfo", "") + HelpExampleRpc("getblockchaininfo", ""));
@@ -1039,7 +1041,7 @@ UniValue getblockchaininfo(const JSONRPCRequest& request)
         NetworkUpgradeDescPushBack(upgrades, consensusParams, Consensus::UpgradeIndex(i), nTipHeight);
     }
     obj.pushKV("upgrades", upgrades);
-
+    obj.pushKV("warnings", GetWarnings("statusbar"));
     return obj;
 }
 

diff --git a/test/functional/rpc_blockchain.py b/test/functional/rpc_blockchain.py
@@ -38,7 +38,7 @@ def set_test_params(self):
         self.num_nodes = 1
 
     def run_test(self):
-        #self._test_getblockchaininfo()
+        self._test_getblockchaininfo()
         self._test_gettxoutsetinfo()
         self._test_getblockheader()
         #self._test_getdifficulty()
@@ -54,6 +54,10 @@ def _test_getblockchaininfo(self):
             'chainwork',
             'difficulty',
             'headers',
+            'initial_block_downloading',
+            'shield_pool_value',
+            'softforks',
+            'upgrades',
             'verificationprogress',
             'warnings',
         ]