Skip to content

Commit

Permalink
Build: Remove no-longer-needed Moc conflict workaround
Browse files Browse the repository at this point in the history
With the GUI's RPC execution code being now de-duplicated, we can do
some additional cleanup for CMake builds and a no-longer-needed
`rpcconsole.moc` include.
  • Loading branch information
Fuzzbawls authored and random-zebra committed Apr 4, 2021
1 parent d763267 commit 4fc2594
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
4 changes: 1 addition & 3 deletions src/Makefile.qt.include
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,7 @@ BITCOIN_MM = \

QT_MOC = \
qt/pivx.moc \
qt/intro.moc \
qt/rpcconsole.moc \
qt/pivx/settings/moc_settingsconsolewidget.cpp
qt/intro.moc

QT_QRC_CPP = qt/qrc_pivx.cpp
QT_QRC = qt/pivx.qrc
Expand Down
7 changes: 0 additions & 7 deletions src/qt/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,6 @@ SET(QT_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/pivx/splash.cpp
)

# Workaround until the old rpcconsole UI window is fully removed
set_property(SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsconsolewidget.cpp PROPERTY SKIP_AUTOMOC ON)
execute_process(
COMMAND ${MOC_BIN} -o moc_settingsconsolewidget.cpp settingsconsolewidget.h
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings
)

execute_process(
COMMAND ${MOC_BIN} -o moc_pfborderimage.cpp pfborderimage.h
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/pivx
Expand Down
4 changes: 0 additions & 4 deletions src/qt/rpcconsole.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
#include "wallet/wallet.h"
#endif // ENABLE_WALLET

#include <univalue.h>

#ifdef ENABLE_WALLET
#include <db_cxx.h>
#endif
Expand Down Expand Up @@ -62,8 +60,6 @@ const struct {
{"misc", ":/icons/tx_inout"},
{NULL, NULL}};

#include "rpcconsole.moc"

RPCConsole::RPCConsole(QWidget* parent) : QDialog(parent, Qt::WindowSystemMenuHint | Qt::WindowTitleHint | Qt::WindowCloseButtonHint),
ui(new Ui::RPCConsole),
clientModel(0),
Expand Down

0 comments on commit 4fc2594

Please sign in to comment.