Skip to content

Commit

Permalink
[Qt] Debug window: remove "Build date".
Browse files Browse the repository at this point in the history 
The build date does only makes sense for custom/self-compiled PIVX-core versions because we are using static build-dates for our deterministic release builds.

Coming from btc@4856f1d6712cdb2eac8712e379fd1e351583d78f

Github-Pull: #2525
Rebased-From: b22dc99
  • Loading branch information
@furszy
furszy committed Sep 19, 2021
1 parent d223d90 commit 51fca36
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 51 deletions.
5 changes: 0 additions & 5 deletions src/qt/clientmodel.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,6 @@ QString ClientModel::formatFullVersion() const
return QString::fromStdString(FormatFullVersion());
}

QString ClientModel::formatBuildDate() const
{
return QString::fromStdString(CLIENT_DATE);
}

bool ClientModel::isReleaseVersion() const
{
return CLIENT_VERSION_IS_RELEASE;
Expand Down
1 change: 0 additions & 1 deletion src/qt/clientmodel.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ class ClientModel : public QObject
QString getStatusBarWarnings() const;

QString formatFullVersion() const;
QString formatBuildDate() const;
bool isReleaseVersion() const;
QString clientName() const;
QString formatClientStartupTime() const;
Expand Down
65 changes: 21 additions & 44 deletions src/qt/forms/rpcconsole.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<item>
<widget class="QTabWidget" name="tabWidget">
<property name="currentIndex">
<number>4</number>
<number>0</number>
</property>
<widget class="QWidget" name="tab_info">
<attribute name="title">
Expand Down Expand Up @@ -113,36 +113,13 @@
</widget>
</item>
<item row="4" column="0">
<widget class="QLabel" name="buildDateLabel">
<property name="text">
<string>Build date</string>
</property>
</widget>
</item>
<item row="4" column="1">
<widget class="QLabel" name="buildDate">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
</property>
<property name="text">
<string>N/A</string>
</property>
<property name="textFormat">
<enum>Qt::PlainText</enum>
</property>
<property name="textInteractionFlags">
<set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
</property>
</widget>
</item>
<item row="5" column="0">
<widget class="QLabel" name="startupTimeLabel">
<property name="text">
<string>Startup time</string>
</property>
</widget>
</item>
<item row="5" column="1">
<item row="4" column="1">
<widget class="QLabel" name="startupTime">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -158,21 +135,21 @@
</property>
</widget>
</item>
<item row="6" column="0">
<item row="5" column="0">
<widget class="QLabel" name="dataDirLabel">
<property name="text">
<string>Data Directory</string>
</property>
</widget>
</item>
<item row="6" column="1">
<item row="5" column="1">
<widget class="QLabel" name="dataDir">
<property name="text">
<string>N/A</string>
</property>
</widget>
</item>
<item row="7" column="0">
<item row="6" column="0">
<widget class="QLabel" name="networkHeader">
<property name="font">
<font>
Expand All @@ -185,14 +162,14 @@
</property>
</widget>
</item>
<item row="8" column="0">
<item row="7" column="0">
<widget class="QLabel" name="networkNameLabel">
<property name="text">
<string>Name</string>
</property>
</widget>
</item>
<item row="8" column="1">
<item row="7" column="1">
<widget class="QLabel" name="networkName">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -208,14 +185,14 @@
</property>
</widget>
</item>
<item row="9" column="0">
<item row="8" column="0">
<widget class="QLabel" name="numberOfConnectionsLabel">
<property name="text">
<string>Number of connections</string>
</property>
</widget>
</item>
<item row="9" column="1">
<item row="8" column="1">
<widget class="QLabel" name="numberOfConnections">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -231,14 +208,14 @@
</property>
</widget>
</item>
<item row="10" column="0">
<item row="9" column="0">
<widget class="QLabel" name="masternodeCountLabel">
<property name="text">
<string>Number of Masternodes</string>
</property>
</widget>
</item>
<item row="10" column="1">
<item row="9" column="1">
<widget class="QLabel" name="masternodeCount">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -254,7 +231,7 @@
</property>
</widget>
</item>
<item row="11" column="0">
<item row="10" column="0">
<widget class="QLabel" name="blockchainHeader">
<property name="font">
<font>
Expand All @@ -267,14 +244,14 @@
</property>
</widget>
</item>
<item row="12" column="0">
<item row="11" column="0">
<widget class="QLabel" name="numberOfBlocksLabel">
<property name="text">
<string>Current number of blocks</string>
</property>
</widget>
</item>
<item row="12" column="1">
<item row="11" column="1">
<widget class="QLabel" name="numberOfBlocks">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -290,14 +267,14 @@
</property>
</widget>
</item>
<item row="13" column="0">
<item row="12" column="0">
<widget class="QLabel" name="lastBlockTimeLabel">
<property name="text">
<string>Last block time</string>
</property>
</widget>
</item>
<item row="13" column="1">
<item row="12" column="1">
<widget class="QLabel" name="lastBlockTime">
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
Expand All @@ -313,21 +290,21 @@
</property>
</widget>
</item>
<item row="14" column="0">
<item row="13" column="0">
<widget class="QLabel" name="lastBlockHashLabel">
<property name="text">
<string>Last block hash</string>
</property>
</widget>
</item>
<item row="14" column="1">
<item row="13" column="1">
<widget class="QLabel" name="lastBlockHash">
<property name="text">
<string>N/A</string>
</property>
</widget>
</item>
<item row="15" column="0">
<item row="14" column="0">
<spacer name="verticalSpacer_2">
<property name="orientation">
<enum>Qt::Vertical</enum>
Expand All @@ -340,7 +317,7 @@
</property>
</spacer>
</item>
<item row="16" column="0">
<item row="15" column="0">
<widget class="QLabel" name="debugLogFileHeader">
<property name="font">
<font>
Expand All @@ -353,7 +330,7 @@
</property>
</widget>
</item>
<item row="17" column="0">
<item row="16" column="0">
<widget class="QPushButton" name="openDebugLogfileButton">
<property name="toolTip">
<string>Open the PIVX debug log file from the current data directory. This can take a few seconds for large log files.</string>
Expand Down
1 change: 0 additions & 1 deletion src/qt/rpcconsole.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ void RPCConsole::setClientModel(ClientModel* model)
// Provide initial values
ui->clientVersion->setText(model->formatFullVersion());
ui->clientName->setText(model->clientName());
ui->buildDate->setText(model->formatBuildDate());
ui->dataDir->setText(model->dataDir());
ui->startupTime->setText(model->formatClientStartupTime());
ui->networkName->setText(QString::fromStdString(Params().NetworkIDString()));
Expand Down

0 comments on commit 51fca36

Please sign in to comment.