Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Fix argument parsing and example for getbalance #2141

Merged
merged 1 commit into from
Jan 16, 2021
Merged

[RPC] Fix argument parsing and example for getbalance #2141

merged 1 commit into from
Jan 16, 2021

Conversation

Fuzzbawls
Copy link
Collaborator

First argument is now a numeric, which needs to be added to the
conversion table. Also fix the example command usage by dropping the no
longer existing "account" argument.

@Fuzzbawls
[RPC] Fix argument parsing and example for getbalance
5128da0 
First argument is now a numeric, which needs to be added to the
conversion table. Also fix the example command usage by dropping the no
longer existing "account" argument.
@Fuzzbawls Fuzzbawls added RPC Bug Trivial extremely simple issues labels Jan 16, 2021
@Fuzzbawls Fuzzbawls added this to the Future milestone Jan 16, 2021
@Fuzzbawls Fuzzbawls self-assigned this Jan 16, 2021
random-zebra
random-zebra approved these changes Jan 16, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5128da0

furszy
furszy approved these changes Jan 16, 2021
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5128da0.

We need test coverage for the RPC commands arguments so this doesn't happen again. And add fuzzing as well.

@furszy furszy merged commit 7ee94ea into PIVX-Project:master Jan 16, 2021
@random-zebra random-zebra modified the milestones: Future, 5.1.0 Jan 17, 2021
@random-zebra random-zebra mentioned this pull request Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@Fuzzbawls Fuzzbawls

Labels
Bug RPC Trivial extremely simple issues
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Fuzzbawls @furszy @random-zebra