Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving masternode check inputs and add process #2186

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Improving masternode check inputs and add process #2186

merged 2 commits into from
Feb 13, 2021

Conversation

furszy
Copy link

@furszy furszy commented Feb 4, 2021

Improvements to the check inputs and add process:

  • Removed an unneeded disk lookup (GetTransaction function call).
  • Removed an unneeded cs_main lock.
  • Added a missing chainActive guard.
  • Cleaned a redundant pcoinsTip access.

@furszy furszy self-assigned this Feb 4, 2021
@furszy furszy added this to the 5.1.0 milestone Feb 5, 2021
random-zebra
random-zebra previously approved these changes Feb 7, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. utACK bbfa102

Fuzzbawls
Fuzzbawls previously approved these changes Feb 13, 2021
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bbfa102

@furszy furszy dismissed stale reviews from Fuzzbawls and random-zebra via 9660555 February 13, 2021 13:47
@furszy furszy force-pushed the 2020_faster_CheckInputsAndAdd branch from bbfa102 to 9660555 Compare February 13, 2021 13:47
@furszy
Copy link
Author

furszy commented Feb 13, 2021

This was conflicting with master, rebased.

random-zebra
random-zebra approved these changes Feb 13, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 9660555 and merging...

@random-zebra random-zebra merged commit 846ef28 into PIVX-Project:master Feb 13, 2021
@furszy furszy deleted the 2020_faster_CheckInputsAndAdd branch November 29, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-zebra random-zebra random-zebra approved these changes

@Fuzzbawls Fuzzbawls Fuzzbawls left review comments

Assignees

@furszy furszy

Labels
Masternode
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@furszy @Fuzzbawls @random-zebra