Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Enable CMake macOS Build #2198

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

Fuzzbawls
Copy link
Collaborator

Fixes the GA descriptor to work with the macOS 10.15 image that GA uses.

Note: Uses clang 11 instead of clang 12 due to a compiler error with the image's clang 12.

Also adds early error reporting for CMake if the configure script fails for any reason.

@Fuzzbawls Fuzzbawls added this to the 5.1.0 milestone Feb 8, 2021
@Fuzzbawls Fuzzbawls self-assigned this Feb 8, 2021
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in GA, good for me, utACK d57709a

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d57709a and merging...

@random-zebra random-zebra merged commit 19f387e into PIVX-Project:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants