Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validation] Remove dead zc checks from ATMP #2213

Merged
merged 4 commits into from
Feb 27, 2021

Conversation

furszy
Copy link

@furszy furszy commented Feb 24, 2021

Since v5 the network is not longer accepting zc transactions. No need to continue having the zerocoin dead code in the accept to mempool function.
This PR cleans it up, removing the unneeded zc mentions in the ATMP process.

@furszy furszy self-assigned this Feb 24, 2021
@random-zebra random-zebra added this to the 5.1.0 milestone Feb 25, 2021
random-zebra
random-zebra previously approved these changes Feb 25, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2a108b6

Fuzzbawls
Fuzzbawls previously approved these changes Feb 27, 2021
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2a108b6

@random-zebra
Copy link

Needs rebase.

@furszy furszy dismissed stale reviews from Fuzzbawls and random-zebra via 315da8c February 27, 2021 12:55
@furszy
Copy link
Author

furszy commented Feb 27, 2021

rebased.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 315da8c and merging...

@random-zebra random-zebra merged commit d499220 into PIVX-Project:master Feb 27, 2021
@furszy furszy deleted the 2020_remove_zc_from_mempool branch November 29, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants