[Refactoring] Prune invalid UTXOs from the coins cache #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202103_invalid-outs-pruning
branch
3 times, most recently
from
374d753
to
9c893fb
Compare
Just rely on the coins cache
random-zebra
force-pushed
the
202103_invalid-outs-pruning
branch
from
9c893fb
to
cdae5b0
Compare
furszy
approved these changes
Mar 12, 2021
Fuzzbawls
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking every possible spent coin against
setInvalidOutPoints(which is rather inefficient), simply prevent the addition of invalid outputs to the coins cache, when they are created (during IBD), and/or prune them at startup.This way we can just rely on the coins cache during block connection, same as with any other coin (invalid outs are simply non-existent / already-spent).