Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] More Descriptive Budget RPCs #2231

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

Liquid369
Copy link
Member

Now 'getbudgetprojection' for isEstablished is more defined.
As well as 'getbudgetinfo' is a little more descriptive.
As per the request in discord just browsed the file for some areas where I think the information could be used.

src/rpc/budget.cpp Outdated Show resolved Hide resolved
@random-zebra random-zebra changed the title [RPC] More Descriptive Budget RPCs [Doc] More Descriptive Budget RPCs Mar 4, 2021
@furszy
Copy link

furszy commented Mar 5, 2021

As getbudgetprojection return only proposals that are passing for the next superblock, the returned values IsEstablished, IsValid and IsInvalidReason are redundant and can be removed, all of them will always be true / not used for every returned item.

Better to modify the base description of getbudgetprojection, adding the requirements for a proposal to be on the returned list. Example of two main requirements that could cause confusion if aren't stated somewhere:

Show the projection of which proposals will be paid the next cycle.
* Proposal fee tx time need to be +24hs old from the current time.
* The net votes value need to be higher than the masternodes count divided by ten.

@random-zebra
Copy link

As getbudgetprojection return only proposals that are passing for the next superblock, the returned values IsEstablished, IsValid and IsInvalidReason are redundant and can be removed

These fields are filled in budgetToJSON, which is used also by getbudgetinfo where they are not redundant.

@Liquid369
Copy link
Member Author

Liquid369 commented Mar 5, 2021

Modifications made and pushed/squashed commits
@random-zebra dangit timing haha

@furszy
Copy link

furszy commented Mar 5, 2021

These fields are filled in budgetToJSON, which is used also by getbudgetinfo where they are not redundant.

@random-zebra, i said that are redundant for getbudgetprojection, not for getbudgetinfo.

src/rpc/budget.cpp Outdated Show resolved Hide resolved
src/rpc/budget.cpp Outdated Show resolved Hide resolved
@Liquid369
Copy link
Member Author

Updated

random-zebra
random-zebra previously approved these changes Mar 5, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. utACK bc50042

src/rpc/budget.cpp Outdated Show resolved Hide resolved
More Descriptive Budget RPCs

More Descriptive Budget RPCs

More Descriptive Budget RPCs

'getbudgetprojection' for isEstablished

'getbudgetinfo' more descriptive

Update getbudgetprojection

More descriptive budget

Be more descriptive
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK be59d5c

@random-zebra random-zebra added this to the 5.1.0 milestone Mar 6, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK be59d5c and merging...

@random-zebra random-zebra merged commit 287973b into PIVX-Project:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants