[GUI] Generate FAQ answer content programmatically #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
previously approved these changes
Apr 12, 2021
Each FAQ answer content is formatted as a self-contained HTML page for styling purposes, however, having raw HTML in the `.ui` file's `<string>` properties means that said HTML tags are also exported to Transifex. This leads to a very ugly and confusing translation experience that is prone to errors. Here, we split up the content into shorter HTML-less strings: each list item is it's own string, and each paragraph is it's own string. No HTML tags are exported to Transifex. The necessary HTML tags are added by way of helper functions that wrap each string programmatically.
Fuzzbawls
force-pushed
the
2021_gui-faq-strings-refactor
branch
from
50cb2f8
to
ea7f593
Compare
|
cleaned up the whitespace |
furszy
approved these changes
Apr 13, 2021
furszy
referenced
this pull request
in furszy/bitcoin-core
Jun 18, 2021
Each FAQ answer content is formatted as a self-contained HTML page for styling purposes, however, having raw HTML in the `.ui` file's `<string>` properties means that said HTML tags are also exported to Transifex. This leads to a very ugly and confusing translation experience that is prone to errors. Here, we split up the content into shorter HTML-less strings: each list item is it's own string, and each paragraph is it's own string. No HTML tags are exported to Transifex. The necessary HTML tags are added by way of helper functions that wrap each string programmatically. Github-Pull: bitcoin#2260 Rebased-From: ea7f593
furszy
added a commit
that referenced
this pull request
Jun 19, 2021
3344fb3 [CI] Remove Ubuntu 16.04 from GA workflow, has been deprecated by GA and will be removed on September 20, 2021. (furszy) b5a8638 [GUI] Cleanup compiler warnings in qtutils.h/cpp (furszy) 73b56e9 [GUI] Fix invisible text due an invalid transparent selection color. (furszy) df5d820 budget: fixing a possible race condition that could cause a good peer being banned. (furszy) a5fd073 Fix minimize and close bugs (furszy) b516e36 depends: update Qt 5.9 source url (Kittywhiskers Van Gogh) 18f4b4a BugFix: fix not updating GUI balance race condition. (furszy) 2c923ed scripted-diff: Replace 'NULL' with 'nullptr' in guiutil.cpp (random-zebra) 7b8b23a Fix memory leaks in qt/guiutil.cpp (Dan Raviv) cbd5c78 Add search option to My Addresses list in receive widget (Volodia) 0dcbea2 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) 3b542fc [Doc] remove old gitian keys. (furszy) 0f099e8 [GUI] Generate FAQ answer content programmatically (Fuzzbawls) 8483861 qt:Show the entire Window when double clicking on taskbar (ken2812221) 998c7e8 [GUI] fix QT 5.15 `currentIndexChanged(QString)` deprecated method call. (furszy) Pull request description: List of straightforward PRs back ported from v6.0 into the v5.2 branch (ordered by merge date). * #2259. * #2260. * #2348 * #2350 * #2353 * #2305 * #2374 * #2379 * #2384 * #2377 * #2395 * #2401 * #2413 ACKs for top commit: random-zebra: utACK 3344fb3 Fuzzbawls: utACK 3344fb3 Tree-SHA512: 4317e83d4c1228b8ae20dc1bc5c8e43ac87598d4d9d9244fdd032f2a0c5eccd1a7ed27bc29094c7411dd653b187c728ab31d732ea686abda15228920a390e4e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each FAQ answer content is formatted as a self-contained HTML page for
styling purposes, however, having raw HTML in the
.uifile's<string>properties means that said HTML tags are also exported toTransifex. This leads to a very ugly and confusing translation
experience that is prone to errors.
Here, we split up the content into shorter HTML-less strings: each list
item is it's own string, and each paragraph is it's own string. No HTML
tags are exported to Transifex.
The necessary HTML tags are added by way of helper functions that wrap
each string programmatically.
Avoids strings such as this one from being passed to Transifex, where spacing, line breaks, and ambiguous numbered "tags" must be carried over to the translated string precisely in order for the translated string to be considered "valid":
