Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Refactoring] Constrain direct wallet access from the GUI in a single place #2293

Merged
merged 12 commits into from
Apr 16, 2021
Merged

[GUI][Refactoring] Constrain direct wallet access from the GUI in a single place #2293

merged 12 commits into from
Apr 16, 2021

Commits on Apr 14, 2021

  1. [Refactoring] Move processBalanceChangeInternal to walletModel

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    422d662 View commit details
    Browse the repository at this point in the history

  2. [Refacotring] Make WalletModel::getBalances private 

    `getBalances` is meant to be used only for the internal polling update
process. Now that `processBalanceChangeInternal` has been encapsulated,
there is no more need to expose `getBalances`.
The rest of the GUI should be using `GetWalletBalances`, which returns
cached data.
    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    cebc900 View commit details
    Browse the repository at this point in the history

  3. [BUG] Incorrect usage of pwalletMain inside GUI walletModel

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    bffe2c5 View commit details
    Browse the repository at this point in the history

  4. [Cleanup][Trivial] Remove unused argument in NotifyKeyStoreStatusChanged

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    50867e2 View commit details
    Browse the repository at this point in the history

  5. [Trivial] Cleanup walletmodel includes

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    733fbc3 View commit details
    Browse the repository at this point in the history

  6. [Refactoring] Move SST / custom fee handling to walletmodel 

    - encapsulate SST settings, and save only in wallet DB
- emit signal when SST changes (to sync GUI with RPC)
    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    87d4979 View commit details
    Browse the repository at this point in the history

  7. [Refactoring][GUI] GetAvailableP2CSCoins inside walletModel

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    4ca5a2a View commit details
    Browse the repository at this point in the history

  8. [Refactoring][GUI] remove pwalletMain direct access in mnmodel

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    beb1cf6 View commit details
    Browse the repository at this point in the history

  9. [Cleanup] Kill MultiSend for good 

    multisend is disabled since long ago, and it won't be re-entroduced in
its current form. Remove all related dead code, including the GUI
widgets, which have also lots of direct accesses to pwalletMain.
    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    5afa2ea View commit details
    Browse the repository at this point in the history

  10. [Refactoring] Add getSaplingAddressString to walletModel

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1a87c44 View commit details
    Browse the repository at this point in the history

  11. [Refactoring][GUI] Remove last remaining pwalletMain calls in the GUI

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    7ec1c65 View commit details
    Browse the repository at this point in the history

  12. [Cleanup] Remove unused optionsdialog

    @random-zebra
    random-zebra committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    012de60 View commit details
    Browse the repository at this point in the history