-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] 5.1.0 backports #2303
Commits on Apr 8, 2021
-
Make box of PIVX address return to purple when it's empty
Github-Pull: bitcoin#2249 Rebased-From: a6a4af1
Configuration menu - View commit details
-
Copy full SHA for 0cf4064 - Browse repository at this point
Copy the full SHA 0cf4064View commit details -
Fixes double fade-in animation when clicking the question mark next t…
…o the 'Available' label in the top bar Github-Pull: bitcoin#2247 Rebased-From: e21a560
Configuration menu - View commit details
-
Copy full SHA for 775e532 - Browse repository at this point
Copy the full SHA 775e532View commit details -
Set fee to highest possible if input is too big #fixes 2234
Set custom transaction fee to highest possible value in case input is too big number. Github-Pull: bitcoin#2237 Rebased-From: ae1837e
Configuration menu - View commit details
-
Copy full SHA for e10c1b6 - Browse repository at this point
Copy the full SHA e10c1b6View commit details -
rpc: Expose g_is_mempool_loaded via getmempoolinfo and
/rest/mempool/info.json And use it to fix a race condition in mempool_persist.py: https://travis-ci.org/Empact/bitcoin/jobs/487577243 Since e.g. getrawmempool returns errors based on this status, this enables users to test it for readiness. Github-Pull: bitcoin#2254 Rebased-From: 0169a75
Configuration menu - View commit details
-
Copy full SHA for 584bbba - Browse repository at this point
Copy the full SHA 584bbbaView commit details -
Move g_is_mempool_loaded into CTxMemPool::m_is_loaded
So the loaded state is explicitly mempool-specific. Github-Pull: bitcoin#2254 Rebased-From: f0de789
Configuration menu - View commit details
-
Copy full SHA for a1d6c0c - Browse repository at this point
Copy the full SHA a1d6c0cView commit details -
[Test] Fix intermittent sync_blocks failures
>>> backports bitcoin/bitcoin@fa3f9a0 Github-Pull: bitcoin#2254 Rebased-From: d076c81
Configuration menu - View commit details
-
Copy full SHA for d902128 - Browse repository at this point
Copy the full SHA d902128View commit details -
test: move sync_blocks and sync_mempool functions to test_framework.py
>>> backports bitcoin/bitcoin@cc84460 Github-Pull: bitcoin#2254 Rebased-From: 2488ebc
Configuration menu - View commit details
-
Copy full SHA for f806584 - Browse repository at this point
Copy the full SHA f806584View commit details -
Co-Authored-By: Wladimir J. van der Laan <laanwj@gmail.com> Plus adapted it to PIVX. Github-Pull: bitcoin#2262 Rebased-From: caa6734
Configuration menu - View commit details
-
Copy full SHA for a582560 - Browse repository at this point
Copy the full SHA a582560View commit details -
[validation] Do not actively wait for cs_main lock in `ActivateBestCh…
…ain()` Github-Pull: bitcoin#2284 Rebased-From: e560afd
Configuration menu - View commit details
-
Copy full SHA for c865148 - Browse repository at this point
Copy the full SHA c865148View commit details -
Removing blocksizenotify abomination.
Essentially, we were re-serializing every new connected block tip just to calculate the size and broadcast a notification for external listeners if the block size is above 1mb. Which well.. (1) the block arrives serialized from the network and it's parsed into a block object by the core, there is no need to re-serialize the entire block.. (2) the complete serialization is just done to notify external listeners if a block exceeds the 1mb block size.. --> which can easily be done from outside of the core without having the most important node processing thread's work notifying nor calculating it, blocking cs_main for its whole time.. Github-Pull: bitcoin#2284 Rebased-From: 479d065
Configuration menu - View commit details
-
Copy full SHA for 4903f31 - Browse repository at this point
Copy the full SHA 4903f31View commit details -
Add Unit Test for SingleThreadedSchedulerClient
Ensures ordering of callbacks within a SingleThreadedSchedulerClient with respect to each other Github-Pull: bitcoin#2290 Rebased-From: 4ea2048
Configuration menu - View commit details
-
Copy full SHA for 9a9425f - Browse repository at this point
Copy the full SHA 9a9425fView commit details -
Update documentation for SingleThreadedSchedulerClient() to specify t…
…he memory model Github-Pull: bitcoin#2290 Rebased-From: cb9bb25
Configuration menu - View commit details
-
Copy full SHA for f499e6e - Browse repository at this point
Copy the full SHA f499e6eView commit details -
Update ValidationInterface() documentation to explicitly specify thre…
…ading and memory model Github-Pull: bitcoin#2290 Rebased-From: f9d2ab3
Configuration menu - View commit details
-
Copy full SHA for c202bc1 - Browse repository at this point
Copy the full SHA c202bc1View commit details -
Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip
Ensures that callbacks are invoked in the order in which the chain is updated Resolves bitcoin#12978 Github-Pull: bitcoin#2290 Rebased-From: ef24337
Configuration menu - View commit details
-
Copy full SHA for 7ab7112 - Browse repository at this point
Copy the full SHA 7ab7112View commit details -
Fix fast-shutdown crash if genesis block was not loaded
If the ShutdownRequested() check at the top of ActivateBestChain() returns false during initial genesis block load we will fail an assertion in UTXO DB flush as the best block hash IsNull(). To work around this, we move the check until after one round of ActivateBestChainStep(), ensuring the genesis block gets connected. Github-Pull: bitcoin#2290 Rebased-From: 8640be1
Configuration menu - View commit details
-
Copy full SHA for c2ae5ff - Browse repository at this point
Copy the full SHA c2ae5ffView commit details -
Optimize ActivateBestChain for long chains
Github-Pull: bitcoin#2290 Rebased-From: 8d15cf5
Configuration menu - View commit details
-
Copy full SHA for fd79bb7 - Browse repository at this point
Copy the full SHA fd79bb7View commit details -
Do not unlock cs_main in ABC unless we've actually made progress.
Technically, some internal datastructures may be in an inconsistent state if we do this, though there are no known bugs there. Still, for future safety, its much better to only unlock cs_main if we've made progress (not just tried a reorg which may make progress). Github-Pull: bitcoin#2290 Rebased-From: 198f435
Configuration menu - View commit details
-
Copy full SHA for fb19c3a - Browse repository at this point
Copy the full SHA fb19c3aView commit details -
Fix concurrency-related bugs in ActivateBestChain
If multiple threads are invoking ActivateBestChain, it was possible to have them working towards different tips, and we could arrive at a less work tip than we should. Fix this by introducing a ChainState lock which must be held for the entire duration of ActivateBestChain to enforce exclusion in ABC. Github-Pull: bitcoin#2290 Rebased-From: a51a755
Configuration menu - View commit details
-
Copy full SHA for 39f6eaf - Browse repository at this point
Copy the full SHA 39f6eafView commit details -
Validation: rename one of the two instances using "bad-prevblk" to it…
…s correct description of "prevblk-not-found" Github-Pull: bitcoin#2290 Rebased-From: f68251d
Configuration menu - View commit details
-
Copy full SHA for c4dd07f - Browse repository at this point
Copy the full SHA c4dd07fView commit details -
Add unit tests for signals generated by ProcessNewBlock()
After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals Adaptation of btc@dd435ad40267f5c50ff17533c696f9302829a6a6 Github-Pull: bitcoin#2290 Rebased-From: 50dbec5
Configuration menu - View commit details
-
Copy full SHA for e51dcee - Browse repository at this point
Copy the full SHA e51dceeView commit details
Commits on Apr 9, 2021
-
[RPC]
getwalletinfo
: Add last_processed_block return value.Github-Pull: bitcoin#2283 Rebased-From: dc2d22a
Configuration menu - View commit details
-
Copy full SHA for b3a12b5 - Browse repository at this point
Copy the full SHA b3a12b5View commit details -
[Tests] Check last_processed_block in getwalletinfo
Github-Pull: bitcoin#2283 Rebased-From: a700fdf
Configuration menu - View commit details
-
Copy full SHA for 7f244b1 - Browse repository at this point
Copy the full SHA 7f244b1View commit details -
Validation: Remove
CheckBlockSignature
now unneeded enableP2PKH flag.It was only needed for the activation period, now that it's fully enforced, can be removed. The activation time isn't needed, v5 enforcement checkpoint is ensuring that the chain cannot reorg to a time in which P2PKH stakes weren't enabled. Github-Pull: bitcoin#2295 Rebased-From: 5aa3600
Configuration menu - View commit details
-
Copy full SHA for a78dfbe - Browse repository at this point
Copy the full SHA a78dfbeView commit details -
Refactor: move
CheckBlockSignature
function call insideCheckBlock
.Github-Pull: bitcoin#2295 Rebased-From: 47cae28
Configuration menu - View commit details
-
Copy full SHA for 374f6c9 - Browse repository at this point
Copy the full SHA 374f6c9View commit details -
Refactor: remove redundant
fAlreadyCheckedBlock
argument from `Acce……ptBlock` `CBlock` has a member `fChecked` that has the exact same purpose as the `fAlreadyCheckedBlock` flag. Github-Pull: bitcoin#2295 Rebased-From: 362a598
Configuration menu - View commit details
-
Copy full SHA for f53c824 - Browse repository at this point
Copy the full SHA f53c824View commit details -
Removal of the
fAlreadyChecked
flag from the entire `ActivateBestCh……ain` flow. Github-Pull: bitcoin#2295 Rebased-From: 6355774
Configuration menu - View commit details
-
Copy full SHA for 1f38b90 - Browse repository at this point
Copy the full SHA 1f38b90View commit details -
validation: missing cs_main lock for
CheckBlock
inProcessNewBlock
Github-Pull: bitcoin#2295 Rebased-From: ce1781e
Configuration menu - View commit details
-
Copy full SHA for c44b431 - Browse repository at this point
Copy the full SHA c44b431View commit details -
validation: Remove redundant request sync from ProcessNewBlock().
ProcessNewBlock is called by ProcessMessage (NetMsgType::BLOCK command) which is doing the exact same check: if the node does not have the previous block, request sync up to it. Github-Pull: bitcoin#2295 Rebased-From: 959936f
Configuration menu - View commit details
-
Copy full SHA for 64bd400 - Browse repository at this point
Copy the full SHA 64bd400View commit details -
net_processing: missing cs_main lock for chainActive.GetLocator() call
Github-Pull: bitcoin#2295 Rebased-From: 21646d8
Configuration menu - View commit details
-
Copy full SHA for 0d2555e - Browse repository at this point
Copy the full SHA 0d2555eView commit details -
Automatically set the lowest possible Custom Fee when user type in fe…
…e that is too low. Github-Pull: bitcoin#2215 Rebased-From: 60bc468
Configuration menu - View commit details
-
Copy full SHA for 1fc145c - Browse repository at this point
Copy the full SHA 1fc145cView commit details -
GUI: if the custom fee is disabled, use the minimum required fee and …
…not the stored value.
Configuration menu - View commit details
-
Copy full SHA for 50a5e84 - Browse repository at this point
Copy the full SHA 50a5e84View commit details