Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test][Misc] Fix libsecp256k1 init for unit test setup + Allow to specify blocks storage directory #2326

Merged

Commits on Apr 20, 2021

  1. Configuration menu
    Copy the full SHA
    7fc893b View commit details
    Browse the repository at this point in the history
  2. Remove unneeded GetTempPath, only use temp directory in unit tests

    Based on btc#6702 btc#6701
    furszy committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5844452 View commit details
    Browse the repository at this point in the history
  3. BugFix: Move TestingSetup::ECCVerifyHandle member to BasicTestingSetup.

    As the libsecp256k1 context was only initialized in the TestingSetup, we have been forced to use it when sometimes it is not necessary (TestingSetup is a complete setup that includes CConnman, scheduler, validation interface, etc).
    furszy committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a821b0b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39b8127 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. QA: Add -blocksdir test

    jonasschnelli authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    3054076 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4ff899 View commit details
    Browse the repository at this point in the history
  3. doc: Clarify -blocksdir usage

    This commit attempts to clarify and correct the `-blocksdir` argument
    description and default value. `-blocksdir` does not refer to the full
    path to the actual `blocks` directory, but rather the root/parent
    directory which contains the `blocks` directory. Accordingly, the
    default value is `<datadir>` and not `<datadir>/blocks`. It also
    attempts to clarify that only the `.dat` files containing block data are
    impacted by `-blocksdir`, not the index files.
    sangaman authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    13a4119 View commit details
    Browse the repository at this point in the history
  4. Make blockdir always net specific

    The blocks directory is net specific by definition.
    
    Also this prevents the side effect of calling GetBlocksDir(false) in the
    non-mainnet environment.
    hebasto authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    ff0ae45 View commit details
    Browse the repository at this point in the history
  5. Improve blocksdir functional test.

    A new node should not create an unused `blocks` directory in the root of
    the data directory when `-testnet` or `-regtest` is specified.
    hebasto authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    e567003 View commit details
    Browse the repository at this point in the history
  6. Fail if either disk space check fails

    Rather than both.
    
    Introduced in 386a6b6
    Empact authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    a571d24 View commit details
    Browse the repository at this point in the history
  7. util: Simplify path argument for CBlockTreeDB ctor

    This commit does not change behavior as GetBlocksDir() with unset
    "-blocksdir" returns the same path.
    hebasto authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    035d3c2 View commit details
    Browse the repository at this point in the history
  8. Turn TryCreateDirectory() into TryCreateDirectories()

    Use case: TryCreateDirectory(GetDataDir() / "blocks" / "index") would
    fail if the blocks directory was not explicitly created before.
    
    The line that did so was in a weird location and could be removed as a
    result.
    Marko Bencun authored and furszy committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    50e66c2 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. Configuration menu
    Copy the full SHA
    b0e0d55 View commit details
    Browse the repository at this point in the history