-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test][Misc] Fix libsecp256k1 init for unit test setup + Allow to specify blocks storage directory #2326
[Test][Misc] Fix libsecp256k1 init for unit test setup + Allow to specify blocks storage directory #2326
Commits on Apr 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7fc893b - Browse repository at this point
Copy the full SHA 7fc893bView commit details -
Remove unneeded GetTempPath, only use temp directory in unit tests
Based on btc#6702 btc#6701
Configuration menu - View commit details
-
Copy full SHA for 5844452 - Browse repository at this point
Copy the full SHA 5844452View commit details -
BugFix: Move TestingSetup::ECCVerifyHandle member to BasicTestingSetup.
As the libsecp256k1 context was only initialized in the TestingSetup, we have been forced to use it when sometimes it is not necessary (TestingSetup is a complete setup that includes CConnman, scheduler, validation interface, etc).
Configuration menu - View commit details
-
Copy full SHA for a821b0b - Browse repository at this point
Copy the full SHA a821b0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b8127 - Browse repository at this point
Copy the full SHA 39b8127View commit details
Commits on Apr 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3054076 - Browse repository at this point
Copy the full SHA 3054076View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ff899 - Browse repository at this point
Copy the full SHA a4ff899View commit details -
This commit attempts to clarify and correct the `-blocksdir` argument description and default value. `-blocksdir` does not refer to the full path to the actual `blocks` directory, but rather the root/parent directory which contains the `blocks` directory. Accordingly, the default value is `<datadir>` and not `<datadir>/blocks`. It also attempts to clarify that only the `.dat` files containing block data are impacted by `-blocksdir`, not the index files.
Configuration menu - View commit details
-
Copy full SHA for 13a4119 - Browse repository at this point
Copy the full SHA 13a4119View commit details -
Make blockdir always net specific
The blocks directory is net specific by definition. Also this prevents the side effect of calling GetBlocksDir(false) in the non-mainnet environment.
Configuration menu - View commit details
-
Copy full SHA for ff0ae45 - Browse repository at this point
Copy the full SHA ff0ae45View commit details -
Improve blocksdir functional test.
A new node should not create an unused `blocks` directory in the root of the data directory when `-testnet` or `-regtest` is specified.
Configuration menu - View commit details
-
Copy full SHA for e567003 - Browse repository at this point
Copy the full SHA e567003View commit details -
Fail if either disk space check fails
Rather than both. Introduced in 386a6b6
Configuration menu - View commit details
-
Copy full SHA for a571d24 - Browse repository at this point
Copy the full SHA a571d24View commit details -
util: Simplify path argument for CBlockTreeDB ctor
This commit does not change behavior as GetBlocksDir() with unset "-blocksdir" returns the same path.
Configuration menu - View commit details
-
Copy full SHA for 035d3c2 - Browse repository at this point
Copy the full SHA 035d3c2View commit details -
Turn TryCreateDirectory() into TryCreateDirectories()
Use case: TryCreateDirectory(GetDataDir() / "blocks" / "index") would fail if the blocks directory was not explicitly created before. The line that did so was in a weird location and could be removed as a result.
Configuration menu - View commit details
-
Copy full SHA for 50e66c2 - Browse repository at this point
Copy the full SHA 50e66c2View commit details
Commits on May 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b0e0d55 - Browse repository at this point
Copy the full SHA b0e0d55View commit details