Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix crash when sending shield notes from the GUI with coin control #2327

Merged
merged 5 commits into from
Apr 23, 2021
Merged

[BUG] Fix crash when sending shield notes from the GUI with coin control #2327

merged 5 commits into from
Apr 23, 2021

Commits on Apr 21, 2021

  1. [Tests] Add basic unit-test for SaplingScriptPubKeyMan::GetNotes 

    Simple test to trigger an assertion failure. Can be enriched in the
future, to check for various configurations.
    @random-zebra
    random-zebra committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c316dda View commit details
    Browse the repository at this point in the history

  2. [Refactoring] Use CWalletTx::DecryptSaplingNote in Get[Filtered]Notes 

    Remove some code duplication
    @random-zebra
    random-zebra committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    28cf3fb View commit details
    Browse the repository at this point in the history

  3. [Trivial] Pass big args by const-reference for notes decryption

    @random-zebra
    random-zebra committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    fbb7813 View commit details
    Browse the repository at this point in the history

  4. [BUG] Missing cs_wallet lock in SaplingScriptPubKeyMan::GetNotes 

    needed by CWalletTx::GetDepthInMainChain
    @random-zebra
    random-zebra committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    85c7425 View commit details
    Browse the repository at this point in the history

  5. [Refactoring] Don't compute depth multiple times in GetFilteredNotes

    @random-zebra
    random-zebra committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    dcc0166 View commit details
    Browse the repository at this point in the history