Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] 5.1.0 bug fixes backports #2334

Merged
merged 6 commits into from
Apr 24, 2021
Merged

[Backport] 5.1.0 bug fixes backports #2334

merged 6 commits into from
Apr 24, 2021

Commits on Apr 22, 2021

  1. [GUI] Fix Cold Staking address list 

    Github-Pull: bitcoin#2321
Rebased-From: 8afb350
    @Fuzzbawls @furszy
    Fuzzbawls authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1886dda View commit details
    Browse the repository at this point in the history

  2. [Tests] Add basic unit-test for SaplingScriptPubKeyMan::GetNotes 

    Simple test to trigger an assertion failure. Can be enriched in the
future, to check for various configurations.
    @random-zebra @furszy
    random-zebra authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    310db82 View commit details
    Browse the repository at this point in the history

  3. [Refactoring] Use CWalletTx::DecryptSaplingNote in Get[Filtered]Notes 

    Remove some code duplication
    @random-zebra @furszy
    random-zebra authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    7d75415 View commit details
    Browse the repository at this point in the history

  4. [Trivial] Pass big args by const-reference for notes decryption

    @random-zebra @furszy
    random-zebra authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    b2d9061 View commit details
    Browse the repository at this point in the history

  5. [BUG] Missing cs_wallet lock in SaplingScriptPubKeyMan::GetNotes 

    needed by CWalletTx::GetDepthInMainChain
    @random-zebra @furszy
    random-zebra authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    9bec9bc View commit details
    Browse the repository at this point in the history

  6. [Refactoring] Don't compute depth multiple times in GetFilteredNotes

    @random-zebra @furszy
    random-zebra authored and furszy committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    68b91b1 View commit details
    Browse the repository at this point in the history