Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Basic multiwallet support #2337

Merged
merged 27 commits into from
May 17, 2021
Merged

[Wallet] Basic multiwallet support #2337

merged 27 commits into from
May 17, 2021

Commits on May 17, 2021

  1. Bugfix: wallet: Increment "update counter" only after actually making 

    the applicable db changes to avoid potential races

Also does all "update counter" access via IncrementUpdateCounter
    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    8aa93b9 View commit details
    Browse the repository at this point in the history

  2. Bug: increment counter when writing minversion

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    8edb74f View commit details
    Browse the repository at this point in the history

  3. CWalletDB: Store the update counter per wallet

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    9cfb711 View commit details
    Browse the repository at this point in the history

  4. refactor: move bdb (bitdb) interaction from init.cpp to wallet.cpp 

    >>> based on bitcoin/bitcoin@2bb1c87

this will remove db.h from init.cpp
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    f9d7fe1 View commit details
    Browse the repository at this point in the history

  5. [Refactor] fix WalletTestingSetup fixture

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    dc2e022 View commit details
    Browse the repository at this point in the history

  6. [Doc] Remove ThreadFlushWalletDB from developer notes 

    It was removed in PIVX-Project#2150
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    fb64bbc View commit details
    Browse the repository at this point in the history

  7. RPC/Wallet: Pass CWallet as pointer to helper functions 

    >>> inspired by bitcoin/bitcoin@eca550f
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    a8dd236 View commit details
    Browse the repository at this point in the history

  8. [Cleanup] Remove un-used printAddresses() function in rpcwallet

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    0e21e09 View commit details
    Browse the repository at this point in the history

  9. RPC: Do all wallet access through new GetWalletForJSONRPCRequest 

    >>> inspired by bitcoin/bitcoin@d77ad6d

currently pwalletMain local variables shadow the global.
These will be renamed to pwallet in the next commit (kept separate for
ease of review)
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    325baaa View commit details
    Browse the repository at this point in the history

  10. [Trivial] Rename pwalletMain --> pwallet for local variables in RPC

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    22f8507 View commit details
    Browse the repository at this point in the history

  11. Move nWalletUnlockTime to CWallet::nRelockTime, and name timed task 

    unique per CWallet
    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    cc965fe View commit details
    Browse the repository at this point in the history

  12. RPC: Pass on JSONRPCRequest metadata (URI/user/etc) for "help" method

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    687c2fd View commit details
    Browse the repository at this point in the history

  13. [MOVE-ONLY] Move wallet RPC declarations to rpcwallet.h 

    based on bitcoin/bitcoin@a435632
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ca6a62d View commit details
    Browse the repository at this point in the history

  14. Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet 

    RPCRunLater job name

The job name is logged, and could pose as an information leak to someone
attacking the process, helping them counteract ASLR protections
    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    3bfa7d8 View commit details
    Browse the repository at this point in the history

  15. Wallet: Sanitise -wallet parameter

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    100d67c View commit details
    Browse the repository at this point in the history

  16. [Wallet] Replace pwalletMain with a vector of wallet pointers 

    >>> adapts bitcoin/bitcoin@b124cf0
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4bbad5c View commit details
    Browse the repository at this point in the history

  17. [Refactor] Remove CWalletDBWrapper::GetUpdateCounter()

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    d6cf608 View commit details
    Browse the repository at this point in the history

  18. [Tests] move pwalletMain to wallet test fixture + use smart pointer 

    >>> inspired by bitcoin/bitcoin@49bd659
              + bitcoin/bitcoin@f94c2ec
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    d10acd5 View commit details
    Browse the repository at this point in the history

  19. Wallet: Support loading multiple wallets if -wallet used more than once

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b27dcfe View commit details
    Browse the repository at this point in the history

  20. Wallet: Move multiwallet sanity checks to CWallet::Verify, and do other 

    checks on all wallets
    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    647fbc9 View commit details
    Browse the repository at this point in the history

  21. wallet: Include actual backup filename in recovery warning message

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    e6efa6b View commit details
    Browse the repository at this point in the history

  22. wallet: Base backup filenames on original wallet filename

    @luke-jr @random-zebra
    luke-jr authored and random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    60f9b4b View commit details
    Browse the repository at this point in the history

  23. wallet: Forbid -salvagewallet, -zapwallettxes, and -upgradewallet with 

    multiple wallets

>>> backports bitcoin/bitcoin@9cbe8c8
    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b6dbbf3 View commit details
    Browse the repository at this point in the history

  24. [Cleanup] Fix formatting in wallet and walletdb

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    36796f2 View commit details
    Browse the repository at this point in the history

  25. [Doc] Add multiwallet section to release notes

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    dc596f3 View commit details
    Browse the repository at this point in the history

  26. [Trivial] Add wallet filename to backup errors/warning

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ff4cee0 View commit details
    Browse the repository at this point in the history

  27. [Cleanup][Tests] Fix chainparams-change in librust tests

    @random-zebra
    random-zebra committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4734a84 View commit details
    Browse the repository at this point in the history