[GUI] Ensure that all UI error/warning texts pass through translation #2388
+50
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds translation where it was previously missing for some `UIError` and `UIWarning` calls. in the case that the string is a pointer, the base string has had translation added. Also parameterized some translation strings to filter out string literals that we DON'T want to be translated (eg '`-wallet`', '`-paytxfee`', etc)
Fuzzbawls
force-pushed
the
2021_translate-uierrors
branch
from
5248add
to
6528ba3
Compare
|
rebased now that #2337 has been merged, ready to go |
furszy
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds translation where it was previously missing for some
UIErrorand
UIWarningcalls. in the case that the string is a pointer, thebase string has had translation added.
Also parameterized some translation strings to filter out string
literals that we DON'T want to be translated (eg '
-wallet','
-paytxfee', etc)