[Consensus] v5.3 network upgrade. #2492
Conversation
There was a problem hiding this comment.
The reason for the crash in the unit test is the assertion at the beginning of CWallet::AddToSpends().
Since we have added the coinbase key without rescanning, mapWallet doesn't contain the coinstake prevout transactions (the actual coinbase transactions).
Aside from this, the guard for negative nMinted in IsBlockValueValid can be set with UPGRADE_V5_3 as well.
EDIT: As emerged in our DM convo: resync is not needed as the blocks are created after importing the key. The issue here is the validation queue not flushed before un-registering the interface in the fixture destructor.
|
kk good 👍 , |
furszy
force-pushed
the
2021_v5.3_NU
branch
3 times, most recently
from
d0f94e5
to
e77a004
Compare
|
Updated. Added the |
So upgraded peers don't create, accept nor broadcast an mnb containing a new addr v2 to non-upgraded peers before the new NU enforcement (introduced in bitcoin#2492).
So upgraded peers don't create, accept nor broadcast an mnb containing a new addr v2 to non-upgraded peers before the new NU enforcement (introduced in bitcoin#2492).
So upgraded peers don't create, accept nor broadcast an mnb containing a new addr v2 to non-upgraded peers before the new NU enforcement (introduced in bitcoin#2492).
So upgraded peers don't create, accept nor broadcast an mnb containing a new addr v2 to non-upgraded peers before the new NU enforcement (introduced in bitcoin#2492).
So upgraded peers don't create, accept nor broadcast an mnb containing a new addr v2 to non-upgraded peers before the new NU enforcement (introduced in bitcoin#2492).
Grouped the consensus changes for the coming v5.3 upgrade.
There is no enforcement height defined to not set it until everything is ready but.. we aren't far from be able to enforce it on testnet and start testing the release deeply, only have to merge #2411 and can be done.