[Test] BIP62 rule 6 added + script tests updates #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_script_tests_updates
branch
2 times, most recently
from
2f8b6f1
to
ab2a4da
Compare
furszy
changed the title
…ove-only commit with the exception of changes to includes.
furszy
force-pushed
the
2021_script_tests_updates
branch
from
4f63c65
to
ec79dcd
Compare
|
Ended up adding btc#7387 and a zc txs standardness policy cleanup as well. More changes over the area will come in a follow-up PR, it is a long rabbit hole. |
random-zebra
reviewed
Sep 9, 2021
Backported from upstream.
NegateSignatureS is called with a signature without a hashtype, so do not save the last byte and append it after S negation. Updates the two tests which were affected by this bug.
The fix to NegateSignatureS caused a test which had been failing in IsValidSignatureEncoding to then fail in IsLowDERSignature. Add new test so the original check remains exercised.
Based on an earlier patch by Peter Todd, though the rules here are different (P2SH scripts should not have a CLEANSTACK check before the P2SH evaluation).
Coming from btc@da918ac06e0d064e9584959ab3d241d03500e972
The 3rd argument of EvalScript() is the unsigned int flags, not a bool. Coming from btc@de236f57c68c2c29d148a2df9e019f431cee3cb7
Backports mostly btc@7517
They claimed to be testing P2SH scripts with non-push scriptSigs, but 1) they were not enabling P2SH 2) they have push-only scriptSigs Fix this, and add a few more related cases.
Fixing formatting Adding test case into automatically generated test case set Clean up commits removing extra whitespace from eol Removing extra whitespace on macro line
furszy
force-pushed
the
2021_script_tests_updates
branch
from
c025890
to
a6d09a9
Compare
|
Added the |
Fuzzbawls
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are way too behind in terms of the script unit tests, this PR pushes us further into upstream's direction.
Back ported PRs: