Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Depends] Use latest config guess/sub #2522

Merged

Conversation

Fuzzbawls
Copy link
Collaborator

@Fuzzbawls Fuzzbawls commented Aug 22, 2021

Allows the depends system to properly identify M1 Mac systems as aarch64-apple-darwin.

@Fuzzbawls Fuzzbawls added this to the 5.4.0 milestone Aug 22, 2021
@Fuzzbawls Fuzzbawls self-assigned this Aug 22, 2021
@Fuzzbawls Fuzzbawls mentioned this pull request Aug 22, 2021
1 task
@random-zebra
Copy link

Have checked with:

git clone git://git.savannah.gnu.org/config.git
cd config && git checkout 4550d2f15b3a7ce2451c1f29500b9339430c877f # last commit of 2021-05-24
cp config.guess config.sub ../PIVX/depends/ && cd ../PIVX
git update-index --assume-unchanged src/chiabls/contrib/relic/include/relic_conf.h.in
git diff

The only difference is that we have no newline at the end of the files.

diff --git a/depends/config.guess b/depends/config.guess
index 57df1f391d..dc0a6b2997 100755
--- a/depends/config.guess
+++ b/depends/config.guess
@@ -1699,4 +1699,4 @@ exit 1
 # time-stamp-start: "timestamp='"
 # time-stamp-format: "%:y-%02m-%02d"
 # time-stamp-end: "'"
-# End:
\ No newline at end of file
+# End:
diff --git a/depends/config.sub b/depends/config.sub
index bb089f1435..7384e9198b 100755
--- a/depends/config.sub
+++ b/depends/config.sub
@@ -1861,4 +1861,4 @@ exit
 # time-stamp-start: "timestamp='"
 # time-stamp-format: "%:y-%02m-%02d"
 # time-stamp-end: "'"
-# End:
\ No newline at end of file
+# End:

@random-zebra
Copy link

Btw... we could pull the actual latest (as of 2021-08-14) version of these files.

Allows the depends system to properly identify M1 Mac systems as aarch64-apple-darwin.
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the latest config files from the gnu repo and the only difference is that still misses the newline at the end of the files.

Other than that, have completed a gitian run with it. So, ACK 8f8d5c0 for me.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8f8d5c0 and merging...

@random-zebra random-zebra merged commit 2781ccd into PIVX-Project:master Oct 2, 2021
random-zebra added a commit that referenced this pull request Oct 8, 2021
dd7b5de [Depends] Bump gmp to v6.2.1 (Fuzzbawls)

Pull request description:

  v6.2.1 of gmp added initial native support for M1 based mac systems

  - [x] #2522

ACKs for top commit:
  furszy:
    regular depends build ACK dd7b5de
  random-zebra:
    ACK dd7b5de and merging...

Tree-SHA512: 2adac416bbb3706017b6a229bfe3e70538c6d662cfa086f395e39821fa7da3bda05f50608752c69f2a8f6104dec0f95a1d2008a8fd1274666021d359b5f6836e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants