[Util] Better URL validation #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We validate (user side) the URL of budget proposals before their submission via RPC, and #soon via the GUI.
As noted by @NoobieDev12 in this comment, this URL validation is too limited. Essentially we are only checking that the string begins with the protocol.
This PR changes the implementation of the function
validateURL(), using C++11std::regex(which was the original intention of #950, but discarded to avoid bumping the minimum supported ABI at the time).I've used the following pattern to match
^(https?)://[^\s/$.?#][^\s]*[^\s/.]\.[^\s/.][^\s]*[^\s.]$, which is far from a complete validation, but it should cover the basic cases.We can refine it in the future if need be.
Unit tests included.