Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Util] Add validation interface logging #2548

Merged
merged 5 commits into from
Sep 23, 2021
Merged

[Util] Add validation interface logging #2548

merged 5 commits into from
Sep 23, 2021

Commits on Sep 12, 2021

  1. Add VALIDATION to BCLog::LogFlags 

    This flag is for logging from within CValidationInterface (see
btc#12994).
A separate flag is desirable as the logging can be noisy and thus may
need to be disabled without affecting other logging.
    @jkczyz @random-zebra
    jkczyz authored and random-zebra committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    dbbf00b View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. [Build] add util/validation build unit 

    >>> coming from bitcoin/bitcoin@91a25d1
    @random-zebra
    random-zebra committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    888eeac View commit details
    Browse the repository at this point in the history

  2. Format CValidationState properly in all cases 

    FormatStateMessage does not properly handle the case where
CValidationState::IsValid() returns true. Use "Valid" for the state in
this case.
    @jkczyz @random-zebra
    jkczyz authored and random-zebra committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d19c880 View commit details
    Browse the repository at this point in the history

  3. Refactor FormatStateMessage for clarity 

    All cases of CValidationState were condensed into one strprintf call.
This is no longer suitable as more cases are added (e.g., IsValid).
    @jkczyz @random-zebra
    jkczyz authored and random-zebra committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d1036c3 View commit details
    Browse the repository at this point in the history

  4. Add logging for CValidationInterface events 

    >>> backports bitcoin/bitcoin@f9abf4a

This could help debug issues where there may be race conditions at play,
such as btc#12978.
    @random-zebra
    random-zebra committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d6fe150 View commit details
    Browse the repository at this point in the history