Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove and deglobalize system.h global variables. #2569

Merged
merged 3 commits into from
Sep 29, 2021
Merged

[Cleanup] Remove and deglobalize system.h global variables. #2569

merged 3 commits into from
Sep 29, 2021

Conversation

furszy
Copy link

@furszy furszy commented Sep 21, 2021

Straightforward cleanup of global variables from system.h that are not needed to be global.

@furszy furszy self-assigned this Sep 21, 2021
@furszy furszy added the Cleanup label Sep 21, 2021
@furszy furszy added this to the 5.4.0 milestone Sep 21, 2021
random-zebra
random-zebra approved these changes Sep 22, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5ab02bc

@furszy
Copy link
Author

furszy commented Sep 29, 2021

moving forward..

@furszy furszy merged commit 9c64f9b into PIVX-Project:master Sep 29, 2021
@furszy furszy deleted the 2021_global_variables_cleanup branch November 29, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-zebra random-zebra random-zebra approved these changes

Assignees

@furszy furszy

Labels
Cleanup
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@furszy @random-zebra