[Refactor] Reorder mnw processing and validation #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
random-zebra
force-pushed
the
202110_mnw-processing-order
branch
2 times, most recently
from
e5b8e02
to
943001a
Compare
|
Rebased on master. Ready to go. |
furszy
previously approved these changes
Oct 19, 2021
There was a problem hiding this comment.
nice refactor, ACK 943001a.
Plus, made a test case for the "non-existent" mnwinner voter: furszy@fa043ae
random-zebra
force-pushed
the
202110_mnw-processing-order
branch
from
943001a
to
26513b9
Compare
|
Rebased, renamed |
furszy
previously approved these changes
Oct 21, 2021
Fuzzbawls
previously approved these changes
Oct 27, 2021
|
I think #2611 has higher priority than this one and should be merged first (as it touches some of the same lines in |
|
yeah, all good, will not merge it yet. |
random-zebra
force-pushed
the
202110_mnw-processing-order
branch
from
70ee3c6
to
e8559fc
Compare
|
Rebased on master, now that #2611 has been merged. |
furszy
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2421 (and based on top of it) so #2550 can be merged in between.