Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Fix "null" backup file name. #2625

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

furszy
Copy link

@furszy furszy commented Nov 2, 2021

New created wallets have no name set by default, thus why the GetUniqueWalletBackupName function returns "null", and the automatic backup process creates backup files with a name in the form of "null+date".

Changed the label to "wallet_backup" instead of "null" if the wallet has no name, plus fixed the rolling functionality that was not cleaning old files.

@furszy furszy self-assigned this Nov 2, 2021
@furszy furszy changed the title [wallet] Fix "null" backup file name. [WIP][wallet] Fix "null" backup file name. Nov 2, 2021
@furszy furszy changed the title [WIP][wallet] Fix "null" backup file name. [wallet] Fix "null" backup file name. Nov 3, 2021
@furszy furszy force-pushed the 2021_wallet_fix_automatic_backup branch from ffe28f1 to e861034 Compare November 3, 2021 00:04
 New created wallets have no name set by default, thus the `GetUniqueWalletBackupName` function returns "null", and the automatic backup process creates a backup file with a name in the form of "null+date".

Changed the label to "wallet_backup" instead of "null" if the wallet has no name.
@furszy furszy force-pushed the 2021_wallet_fix_automatic_backup branch from e861034 to 3d97ae9 Compare November 3, 2021 02:16
@furszy furszy added this to the 5.4.0 milestone Nov 5, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3d97ae9

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d97ae9

@furszy furszy merged commit 452465f into PIVX-Project:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants