Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Correct proposal large title for being cut when the app window width isn't big enough #2627

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

furszy
Copy link

@furszy furszy commented Nov 4, 2021

Found it while was testing #2626, a small bug that occurs when the app window width isn't big enough to automatically expand the three column grid proposal cards. So the last letter of proposals with large names are being cut.

For example, look at the proposal in the middle:

Before the fix:
Screen Shot 2021-11-04 at 6 44 15 PM

After the fix:
Screen Shot 2021-11-04 at 6 40 09 PM

@furszy furszy self-assigned this Nov 4, 2021
@random-zebra random-zebra added this to the 5.4.0 milestone Nov 5, 2021
@random-zebra
Copy link

At some width (such that the grid has still three columns), some proposal may still have the name partially cut (also the vertical scrollbar covers the last column, but no big deal):

Screenshot

Maybe (as suggested) we could add a tooltip for labelPropName.

@furszy
Copy link
Author

furszy commented Nov 5, 2021

interesting, it does not happen in macOS. But well, yeah.. added the tooltip text as well 👍 .
it only happen at some specific width when the grid has three columns but not enough space due the card minimum size. Will work on this specific case later on.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4de2338

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4de2338

I think that the edge cases surrounding outlier pixel widths are really not worth investing time into right now. If anything, create an issue and mark it for future work, so it can be referenced if/when any users report the issue.

@furszy furszy merged commit 02a0060 into PIVX-Project:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants