[validation] Create zerocoin coinspends cache #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_zc_coinspend_cache
branch
from
5ac00bf
to
6b803fb
Compare
|
feedback tackled. |
Fuzzbawls
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially a zerocoin coinSpends cache layer to speedup the blockchain synchronization process during the period of time where blocks contained zerocoin transactions (which is the slowest period).
The reason behind this is that the sources are parsing and re-parsing the same zc transaction coinspend script over and over in different parts of the block validation circuit such as:
(1) block signature validation, (2) CheckZerocoinSpend, (3) ParseAndValidateZerocoinSpends, (4) CheckInBlockDoubleSpends, (5) IsUnspentOnFork, (6) ZPoS contextual checks, (7) NewZPivStake.
Pending to do: measure the blocks synchronization time improvement.