-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Decouple legacy MNs code from the GUI elements #2721
[GUI] Decouple legacy MNs code from the GUI elements #2721
Conversation
Ended up moving the collateral min conf value to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e364c34. Just few nits
e364c34
to
c42547e
Compare
updated per feedback, nits tackled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force-push utACK c42547e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c42547e
…N inside MNModel.
This field is used for both types, legacy and deterministic.
c42547e
to
42b6a73
Compare
rebased, conflicts solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a little bug.
42b6a73
to
18e270d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 18e270d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK 18e270d
…fix and more circ dependencies fixes 4e14d21 bug: remove 'evodb' dir during -resync (furszy) 7408131 init: move 'pEvoNotificationInterface' initialization, reset and register to tiertwo/init.cpp (furszy) 922fa05 wallet: merge GetMasternodeVinAndKeys and GetVinAndKeysFromOutput functions. (furszy) 083fcad Move masternodeconfig initialization to tiertwo/init (furszy) Pull request description: Built on top of #2721, decoupled from the DMN GUI branch. Focused on the following points: * Unify `masternodeconfig` duplicated initialization inside `tiertwo/init.cpp`. Same for the `pEvoNotificationInterface` class. * Simplify and unify `CWallet::GetMasternodeVinAndKeys` and `CWallet::GetVinAndKeysFromOutput` functions. * Bug fix: remove 'evodb' dir during `-resync`. * Fix the following circular dependencies: --> "masternode -> wallet/wallet -> masternode" --> "chain -> legacy/stakemodifier -> stakeinput -> wallet/wallet -> evo/deterministicmns -> chain" Next PR will be exclusively focused on the new tier two module. ACKs for top commit: random-zebra: force-push utACK 4e14d21 Tree-SHA512: 1c74975acb926f2410f651fc95c5dc437aa1b272ad4e0b27c50087d96908d183d85dd5b9c11528482d25d3062a1efc80bdf0567098724157912bb2a68566a5cc
Encapsulating the legacy Masternodes code that is spread over the GUI widgets inside the MN module.
Plus, as is a value shared between legacy and deterministic Masternodes, moved the collateral min conf field to
chainparams
. Which allowed to remove the following circular dependency:"evo/deterministicmns -> masternode -> wallet/wallet -> evo/deterministicmns"
Part of the building blocks for adding visual support for the new deterministic Masternodes features.