-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish moving tier two initialization code from init.cpp to tiertwo/init.cpp and add disabledkg init flag #2723
Finish moving tier two initialization code from init.cpp to tiertwo/init.cpp and add disabledkg init flag #2723
Conversation
1f6aadd
to
7be3367
Compare
1) Walk-through the DMN list only once instead of one-time per wallet. 2) Remove wallet dependency on evo/deterministicmns.h.
…al transactions' output lock in wallet to the tiertwo/init.cpp file.
7be3367
to
cc0fdeb
Compare
Rebased on master, ready to go. Forgot to mention on the PR description that this is removing another circular dependency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code ACK cc0fdeb
Updating p2p_quorum_connect.py test with it And move -pushversion to GetTierTwoHelpString as well.
cc0fdeb
to
c445333
Compare
updated per feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c445333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c445333
Follow-up to #2684, built on top of #2647. Starting in 296e6fa.
Focused on the following points:
GetTierTwoHelpString()
, the tier two objects initializers and the Masternodes collateral output locking process to the tiertwo/init files.evo/deterministicmns.h
.-disabledkg
init argument so thep2p_quorum_connect.py
functional test does not get affected by the automatic DKG sessions processes (coming in Long Living Masternode Quorums - Part 3, DKG #2722). The same flag will be used in other future tests that perform manual operations as well.