Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Reorganize and optimize GA runner flow #2825

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

Fuzzbawls
Copy link
Collaborator

Base re-organization work for our GitHub Actions flow.

  • Removed syslibs from x64 linux depends builds. This was a holdover from when we were using Travis CI, which had a very restrictive job length.
  • Split syslib-only builds out from depends builds. There is no reason to require depends cache to succeeded for syslib-only builds.
  • syslib builds can benefit from enabling debug options.
  • standardize job naming to NOT include the distro name. This will make future runner OS bumps easier as protected branches use the job name as the standard for job matching purposes.

This is a precursor to additional work that will add more GA jobs to the syslib-only section, which will further benefit from parallelization.


Note to reviewers: Because this PR changes the names of jobs, the GitHub UI will never show this PR as "passing" the "expected jobs" (because the names have been changed). Once this PR is merged, the branch protection rules will be updated accordingly, and subsequent PRs submitted that are built on top of this PR will have the appropriate required GA tests marked as "required".

Test runners that don't depend on prior depends builds should be able to
 run before the depends cache is finished building, similar to how CMake
  builds are allowed to run in parallel.
- Remove distro names from the matrix name. will ease future updating.
- Remove extra whitespace in matrix names.
@Fuzzbawls Fuzzbawls added this to the 6.0.0 milestone Mar 16, 2023
@Fuzzbawls Fuzzbawls self-assigned this Mar 16, 2023
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b0b609e
Tests passing for me in my repo

Copy link

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b0b609e

@Fuzzbawls Fuzzbawls merged commit e1e376e into PIVX-Project:master Apr 12, 2023
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.6.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants