[GUI] Fix ban actions in peer list #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liquid369
force-pushed
the
2023_gui_bantable_fix
branch
from
9c59c97
to
2370d90
Compare
panleone
requested changes
Apr 17, 2023
|
I will take a look, problem beforehand was resolving and looking it up |
Liquid369
force-pushed
the
2023_gui_bantable_fix
branch
from
046ca98
to
d33efa3
Compare
|
New way pushed, no longer tracking the address, but that itself is still tracked as addrName as a string, to which we can use for this instead. |
panleone
previously approved these changes
Apr 20, 2023
Fuzzbawls
requested changes
May 2, 2023
Fix whitespace
Liquid369
force-pushed
the
2023_gui_bantable_fix
branch
from
73bd32d
to
a86ab9e
Compare
Fuzzbawls
approved these changes
May 3, 2023
panleone
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For quite some time in the PIVX GUI we have the old UX for the peer list, and it has not been functional to ban peers using the context menu.
See below:
Any amount of clicks, it will not ban said peer nor will it update the ban list.
With this PR it is now working as intended again
Clicking ban node for X time, will automatically disconnect the peer and update the GUI/ban list
Changes:
We now track the nodes address in the NodeStats class, and so now we do not need to resolve the IP but rather pull it from the stats we have access to after syncing the information from the node.