-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Locked sapling notes #2861
Conversation
50826ca
to
141fb78
Compare
rebased on master to resolve conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 141fb78
Working pretty well, RPCs work nicely, and a nice quality of life improvement for shield users.
had to rebase again due to new conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 2d5d42b
Still working after rebasing, gg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2d5d42b
This PR implements the possibility to lock a sapling note, so the system will not try to spend it once a shield transaction is made. As for normal utxo locks are not saved on disk.
In particular I have updated two RPCs:
I have also updated the coin control interface so users will be able to lock a note from the GUI.