[Bug] [GUI] Fix focus on send transaction #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Aug 10, 2023
panleone
pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 10, 2024
This avoids calling WakeupSelect() for each node instead of just once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial but quite annoying bug fix. Basically once a transaction is actually sent from the GUI (so a few seconds after the user presses on "SEND" in the confirmation screen) the focus goes back to the "Recipient address" field regardless the screen the user is currently on.
Now once the "SEND" button is pressed the focus on "Recipient address" is already (and istantly) gained by the function
showEventin send.cpp, so to fix this issue I simply removed the call tosetFocusOnLastEntrythat happens when the transaction is actually sent (which is therefore completely useless).This PR also solves #2597 and #1566