Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLS] [TEST] Update bls batchverifier #2885

Merged
merged 2 commits into from
Sep 30, 2023
Merged

[BLS] [TEST] Update bls batchverifier #2885

merged 2 commits into from
Sep 30, 2023

Conversation

panleone
Copy link

@panleone panleone commented Sep 9, 2023

The first commit updates bls_batchverifier.h to the most recent upstream version
The second commit adds unit tests for the batchverifier

@panleone panleone self-assigned this Sep 9, 2023
@panleone panleone added this to the 6.0.0 milestone Sep 9, 2023
Liquid369
Liquid369 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3ad1254f59017aedc499cc49c1c736735ecc7d3f94140190ba1aeccef3043197

Fuzzbawls
Fuzzbawls approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbada5b

@Fuzzbawls
Copy link
Collaborator

tACK 3ad1254f59017aedc499cc49c1c736735ecc7d3f94140190ba1aeccef3043197

@Liquid369 can you please re-review, your commit hash in this comment doesn't match up

Liquid369
Liquid369 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fbada5b

sorry not sure what got mixed up there

@Fuzzbawls Fuzzbawls merged commit 563454e into PIVX-Project:master Sep 30, 2023
21 checks passed
@panleone panleone deleted the update_bls_batchverifier branch March 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@Liquid369 Liquid369 Liquid369 approved these changes

Assignees

@panleone panleone

Labels
Tests Upstream Dash
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@panleone @Fuzzbawls @Liquid369