[Scripts][GUI] Overhaul translation ingestion script and update translations from Transifex #2892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
update-translations.py
was in dire need of updating since Transifex depreciated their oldtx
CLI utility in favor of their new CLI utility (of the same name). Minor changes to the.tx/config
file format were needed to be compliant, and the translation ingestion script itself (update-translations.py
) was updated to be more in-line with upstream's version, with some additional Flake8/PEP compliance rules being adhered to.The first commit is really the only commit that needs actual code review. The second commit is automatically generated changes resulting from running the
update-translations.py
script, with ONE caveat: I changed the minimum translation threshold from 80% to 50% solely for the purpose of not loosing any already translated languages.I felt this necessary for the
master
branch (which will never be used for final release translations) simply to showcase that translating the core wallet is an ongoing process that is never truly "finished", as strings change or new strings get introduced between wallet release versions.It also gives users of otherwise incomplete translated languages a chance to view how their language translations appear in a compiled GUI wallet, and provide feedback if there are any clipping issues.
This PR does introduce two completely new wallet translations never before seen with PIVX:
And now for the part where we need some more help prior to the final 6.0 release;
The following languages are in jeopardy of being EXCLUDED from the final 6.0 release unless they can reach a minimum of 80% translated strings. Listed in descending order based on completion percentage:
Any translator that has contributed translations via Transifex for the PIVX Core wallet is highly encouraged to check-in on the Transifex website, as no language (other than the English source) is 100% complete at the time of writing this PR.
Anyone not already part of the PIVX translation effort on Transifex that would like to join the effort, you can goto https://explore.transifex.com/pivx-project/ and request to join the
PIVX Core Wallet
project.**Note: the completion percentages represented on the public page are TOTAL over all resource versions available (we keep many historical resource versions for archival purposes), and NOT indicative of the specific targeted resource version percentages listed above