-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Bump Boost to 1.81.0 #2940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 4fffec0
The merge-base changed after approval.
Dot is used as a separator in versions of other depends packages.
Ubuntu 24.04 upgrades the gcc/g++ compiler to version 13, which introduces some incompatibilities. Pin to 22.04 for now.
60069e3
to
d3ff548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK d3ff548
testing are passing again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK d3ff548
Bump the version of Boost we use to 1.81.0 for depends, and remove the Boost version specifier in macOS CI jobs. The current macOS CI jobs use a deprecated package
boost@1.76
, which has started to cause errors. That package is scheduled to be removed from brew.sh repositories in December, so instead of patching in compatibility for it (again), move on to the un-versioned Boost package.Last commit was just added as GA updated the
ubuntu-latest
OS to Ubuntu 24.04, which has compile errors due to gcc 13, so for now we pin "latest" to 22.04.