Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitian hack so gitian Mac builds notify user about incompatibility on High Sierra #382

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Conversation

jonspock
Copy link

@jonspock jonspock commented Nov 10, 2017

With this change, if a user tries to open on High Sierra from official gitian build, they'll see the following
screen shot 2017-11-10 at 2 50 21 pm

However, could will let users on High Sierra still build and use as long as they are using Clang version 4 or higher

@ghost ghost assigned jonspock Nov 10, 2017
@ghost ghost added the review label Nov 10, 2017
@Fuzzbawls
Copy link
Collaborator

needs a rebase to filter out the extra commits, should only include 2005e9b. Otherwise it looks ok for a temporary fix.

@jonspock
Copy link
Author

rebased

@Fuzzbawls
Copy link
Collaborator

utACK a2efe3d

@Mrs-X
Copy link

Mrs-X commented Nov 11, 2017

utACK and merging...

@Mrs-X Mrs-X merged commit a2efe3d into PIVX-Project:master Nov 11, 2017
Mrs-X added a commit that referenced this pull request Nov 11, 2017
…atibility on High Sierra

a2efe3d Gitian Hack (Jon Spock)

Tree-SHA512: 99efdb6894beb9546474bc918c525df3987a5f60a25a92c7f437bec272cb0034fc4e89417a013890cd5d46abfcda5e1652807185f8d252a2174236f66ef0cfa5
@ghost ghost removed the review label Nov 11, 2017
@Fuzzbawls Fuzzbawls added this to the 3.0.5 milestone Nov 11, 2017
@jonspock jonspock deleted the gitian_hack branch November 11, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants